Skip to content

gh-103878: Ensure canceled file dialog returns ""#111195

Closed
chrstphrchvz wants to merge 2 commits into
python:mainfrom
chrstphrchvz:patch-gh103878
Closed

gh-103878: Ensure canceled file dialog returns ""#111195
chrstphrchvz wants to merge 2 commits into
python:mainfrom
chrstphrchvz:patch-gh103878

Conversation

@chrstphrchvz

@chrstphrchvz chrstphrchvz commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
@serhiy-storchaka

Copy link
Copy Markdown
Member

Thanks for this — sorry it sat so long.

I've reimplemented the same normalization in #152435, which also fixes the root cause (Open._fixresult() dispatched single-vs-multiple by result type, so an empty () was misread as a multiple selection) and adds tests. You're credited as co-author there, since you fixed the ""-vs-()/b"" inconsistency first.

Closing as superseded by #152435 — thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time. topic-tkinter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants